duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs
https://duckduckhack.com/
Other
548 stars 942 forks source link

Dictionary Definition: Shows durham for dirham #3322

Closed adityatandon007 closed 7 years ago

adityatandon007 commented 7 years ago

Issue I was searching for the currency dirham because I was working on currency IA and when I searched dirham this IA triggered and showed the result for durham

Screenshot

screenshot from 2017-06-08 16-36-48

People to notify @moollaza @mintsoft


IA Page: http://duck.co/ia/view/dictionary_definition Maintainer: @jagtalon

pjhampton commented 7 years ago

Yeah, I'm fine for you to take this forward @adityatandon007. I think that currency should have a higher signal that the dictionary IA.

adityatandon007 commented 7 years ago

@pjhampton I didn't get what you meant in the previous comment.

I'm fine for you to take this forward @adityatandon007

You closed the issue and wanted me to take this forward. How I am gonna take this forward if the issue itself is closed.

pjhampton commented 7 years ago

As I mentioned here https://github.com/duckduckgo/zeroclickinfo-spice/issues/3321#issuecomment-308046715

For minor, incremental improvements we don't need to create issues. Just submit an unsolicited PR in future.

edit: Also here: https://github.com/duckduckgo/zeroclickinfo-spice/issues/3321#issuecomment-307832530

adityatandon007 commented 7 years ago

@pjhampton thanks for clearing that. I would remember this next time