Brainy Quotes: ellipsis cuts off too much of the quote

duckduckgo / zeroclickinfo-spice

DuckDuckGo Instant Answers based on JavaScript (JSON) APIs

https://duckduckhack.com/

Other

548 stars 942 forks source link

Brainy Quotes: ellipsis cuts off too much of the quote #805

Closed russellholt closed 9 years ago

russellholt commented 10 years ago

for example 'john kennedy quote' gives

As we express our gratitude, we must never forget that the highest appreciation is...

...is what? what is it?!

https://duck.co/ia/view/brainy_quote

anirudh24seven commented 10 years ago

Seems like it cuts the quote after 85 characters: https://github.com/duckduckgo/zeroclickinfo-spice/blob/3bcc87bcd57dffa0ce33da4ba96417edcd7bec37/share/spice/brainy_quote/content.handlebars#L3

What is the suggested limit? 120? 140?

russellholt commented 10 years ago

there are some long ones, like http://www.brainyquote.com/quotes/quotes/d/drdre481455.html which is 348. the question is whether to cut them off at all. 200 is probably ok.

jagtalon commented 9 years ago

@moollaza @russellholt what do you think about using the "info" template, but with a bigger font-size? It has the "Show more ..." thing which we want for BrainyQuotes.

screen shot 2014-12-09 at 4 16 53 pm

moollaza commented 9 years ago

Sounds good to me :+1: Let's see how it looks

russellholt commented 9 years ago

Not a great answer. Chris is working on standardizing this, let's not break the standards by default

killerfish commented 9 years ago

We can switch this to text template (its using base currently), no? Would possibly resolve #674 also.