5 mins of tuning of the PID gains dramatically improves the performance of lane following in the simulator. Requires https://github.com/duckietown/dt-ros-commons/pull/55 to be merged since we define the parameters in an agent.yaml file sinec agent is the name of the robot in simulation.
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Explicitly mention if the current changes can (or could) break any existing interface or functionality.
If this pull request results in from a fix to a GitHub issue, give a link to it.
Type of change
Please mark the relevant options with X:
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change is constrained only to one package, any interfaces to nodes from other packages are maintained
[ ] This change is constrained only to packages in this repository, any interfaces to nodes from other repositories are maintained
[ ] This change required a documentation update
[ ] This change is only a documentation update
[ ] This change restructures the repository (at level higher than package level)
[ ] This change requires a change in the Duckiebook (if yes, please describe and, if possible, make a pull request for an edit in the book and link it here)
Tests
Please describe all tests ran and their outcome. It is highly recommended that you at least do the tests listed by default, even if you only changed the documentation.
[ ] Made the Duckiebot move with keyboard control
[ ] Visually checked the published camera stream
[ ] Verified that the lane following demo works
[ ] Verified that the indefinite navigation demo works
Style compliance
Please make sure that all your changes conform to the Duckietown (code style)[link] and code (documentation style)[link] guidelines:
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I checked that this pull request is compliant with the Duckietown code style
[ ] I checked that this pull request is compliant with the Duckietown code documentation style
Next steps
Please describe if you have any questions, comments, or doubts towards the Duckietown software guardians regarding implementation, code style, running tests, documentation, etc.
FOR THE REVIEWERS
IMPORTANT: DO NOT CHANGE THIS SECTION!
[ ] Functionality (is the change necessary and is it implemented in the most appropriate way): @liampaull or @afdaniele
[ ] Integration testing (verify the tests and run additional if necessary): @?
[ ] Code style compliance: @gibernas
[ ] Documentation compliance: @aleksandarpetrov
To the reviewers: If you deem necessary, request code edits, more tests, documentation update, or additional reviewing. Do not review your own code!
Description
5 mins of tuning of the PID gains dramatically improves the performance of lane following in the simulator. Requires https://github.com/duckietown/dt-ros-commons/pull/55 to be merged since we define the parameters in an
agent.yamlfile sinec agent is the name of the robot in simulation.Type of change
Please mark the relevant options with X:
Tests
Please describe all tests ran and their outcome. It is highly recommended that you at least do the tests listed by default, even if you only changed the documentation.
Style compliance
Please make sure that all your changes conform to the Duckietown (code style)[link] and code (documentation style)[link] guidelines:
Next steps
Please describe if you have any questions, comments, or doubts towards the Duckietown software guardians regarding implementation, code style, running tests, documentation, etc.
FOR THE REVIEWERS
IMPORTANT: DO NOT CHANGE THIS SECTION!
To the reviewers: If you deem necessary, request code edits, more tests, documentation update, or additional reviewing. Do not review your own code!
PR Template, last edit 23 Aug 2019