Adding yellow to the predefined LED patters since yellow LEDs were helpful to increase the recognition of the yellow lines
Description
I had problems to detect the yellow lines in the middle of the road as they were recognized as white lines.
Switching the leds to yellow seemed to increase the recognition rate while still detecting the white lines as white.
However to do that I had to add yellow as a custom pattern so including it in the default ones might be helpful so that it can be changed easily with a single rosservice call.
This shouldn't break anything as the color is already defined in the same file above and the pattern is defined similar to the other single color patterns. This also already works on my local duckiebot without any problem.
Type of change
Please mark the relevant options with X:
[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] This change is constrained only to one package, any interfaces to nodes from other packages are maintained
[ ] This change is constrained only to packages in this repository, any interfaces to nodes from other repositories are maintained
[ ] This change required a documentation update
[ ] This change is only a documentation update
[ ] This change restructures the repository (at level higher than package level)
[ ] This change requires a change in the Duckiebook (if yes, please describe and, if possible, make a pull request for an edit in the book and link it here)
Tests
Please describe all tests ran and their outcome. It is highly recommended that you at least do the tests listed by default, even if you only changed the documentation.
[X] Made the Duckiebot move with keyboard control
--> no changes
[X] Visually checked the published camera stream
--> no change until led_emitter node is run and rosservice is called. Then yellow lines were slightly better recognized as yellow lines by the lane_filter node.
[ ] Verified that the lane following demo works
[ ] Verified that the indefinite navigation demo works
Style compliance
Please make sure that all your changes conform to the Duckietown (code style)[link] and code (documentation style)[link] guidelines:
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I checked that this pull request is compliant with the Duckietown code style
[X] I checked that this pull request is compliant with the Duckietown code documentation style
Next steps
Please describe if you have any questions, comments, or doubts towards the Duckietown software guardians regarding implementation, code style, running tests, documentation, etc.
Maybe the other predefined colors should also be provided as patterns so that they can easily be changed for debug purposes.
FOR THE REVIEWERS
IMPORTANT: DO NOT CHANGE THIS SECTION!
[ ] Functionality (is the change necessary and is it implemented in the most appropriate way): @liampaull or @afdaniele
[ ] Integration testing (verify the tests and run additional if necessary): @?
[ ] Code style compliance: @gibernas
[ ] Documentation compliance: @aleksandarpetrov
To the reviewers: If you deem necessary, request code edits, more tests, documentation update, or additional reviewing. Do not review your own code!
afdaniele
commented
1 year ago
Adding yellow to the predefined LED patters since yellow LEDs were helpful to increase the recognition of the yellow lines
Description
I had problems to detect the yellow lines in the middle of the road as they were recognized as white lines. Switching the leds to yellow seemed to increase the recognition rate while still detecting the white lines as white. However to do that I had to add yellow as a custom pattern so including it in the default ones might be helpful so that it can be changed easily with a single rosservice call.
This shouldn't break anything as the color is already defined in the same file above and the pattern is defined similar to the other single color patterns. This also already works on my local duckiebot without any problem.
Type of change
Please mark the relevant options with X:
Tests
Please describe all tests ran and their outcome. It is highly recommended that you at least do the tests listed by default, even if you only changed the documentation.
Style compliance
Please make sure that all your changes conform to the Duckietown (code style)[link] and code (documentation style)[link] guidelines:
Next steps
Please describe if you have any questions, comments, or doubts towards the Duckietown software guardians regarding implementation, code style, running tests, documentation, etc.
Maybe the other predefined colors should also be provided as patterns so that they can easily be changed for debug purposes.
FOR THE REVIEWERS
IMPORTANT: DO NOT CHANGE THIS SECTION!
To the reviewers: If you deem necessary, request code edits, more tests, documentation update, or additional reviewing. Do not review your own code!
PR Template, last edit 23 Aug 2019