search

duckietown / gym-duckietown

Self-driving car simulator for the Duckietown universe
http://duckietown.org
Other
52 stars 19 forks source link

Not compatible with python 3.5+ anymore #148

Closed manfreddiaz closed 5 years ago

manfreddiaz commented 5 years ago

A newly added dependency dataclasses have rendered the simulator incompatible with any python version below 3.7.

    from dataclasses import dataclass
ModuleNotFoundError: No module named 'dataclasses'

In python 3.6, we can use pip install dataclasses as a workaround but I am not sure if this brings other compatibility issues.

bhairavmehta95 commented 5 years ago

Took the easy way out on this way, fixed in aido2 branch

AI-Guru commented 5 years ago

Unfortunately dataclasses is back. Removing python 3.5 compatibility.

liampaull commented 5 years ago

@bhairavmehta95 should this issue be re-opened?

bhairavmehta95 commented 5 years ago

I think with the dataclasses, we just need to say its Py3.6 only. It's all a bit too "integrated" to make everything backwards compatible (based on some of the other DT infrastructure stuff)

AI-Guru commented 5 years ago

It looks to me that dataclasses are used only once in the entire codebase. I would vote for keeping 3.5 compatibility.