A suggested solution to fix collision issues with dynamic duckiebots

duckietown / gym-duckietown

Self-driving car simulator for the Duckietown universe

http://duckietown.org

Other

52 stars 19 forks source link

A suggested solution to fix collision issues with dynamic duckiebots #217

Closed kaland313 closed 4 years ago

kaland313 commented 4 years ago

Fixes #216. Also, if there are no static obstacles, therefore len(self.collidable_corners) == 0, collision with dynamic obstacles is still checked.

CourchesneA commented 4 years ago

@bhairavmehta95 looks like this is some code that you worked with, could you have a look at the changes ?

bhairavmehta95 commented 4 years ago

Seems reasonable to me

kaland313 commented 4 years ago

@bhairavmehta95 Shouldn't these changes be merged into daffy-aido4 as well? (The issue exists there, see #216 )

CourchesneA commented 4 years ago

@kaland313 This would not really be a problem since we will fix the conflicts once we merge daffy-aido4 in daffy, but I merged your PR in there anyways to save trouble down the line. Thanks for the fix !