duckietown / gym-duckietown

Self-driving car simulator for the Duckietown universe
http://duckietown.org
Other
51 stars 19 forks source link

Modularize code #37

Closed bhairavmehta95 closed 6 years ago

bhairavmehta95 commented 6 years ago

simplesim_env.py is over 1000 lines now, so I propose that we pull some code out into some other files:

Ideally, we keep step(), render() (and its helper functions), reset(), and init() (which can also become a bit more modularized) inside of simplesim, and move everything else out.

maximecb commented 6 years ago

So, I think we aren't quite going in the direction you suggested, but we did do some refactoring with the object refactoring. One possibility would be to convert the agent itself into a world object class. Might make some sense. Though the agent will always require some special treatment by the simulator.

bhairavmehta95 commented 6 years ago

I'd actually say we've made some good progress in this direction, closing.