search

duckietown / gym-duckietown

Self-driving car simulator for the Duckietown universe
http://duckietown.org
Other
51 stars 19 forks source link

adding joystick changes #50

Closed bhairavmehta95 closed 6 years ago

bhairavmehta95 commented 6 years ago

Adding almost all changes requested in #33 .

X button now stops the recording and deletes in no matter what. If episode finishes when recording, recording is now stopped & saved and the episode resets.

The only thing not added is the double joystick control - usually, double joysticks (one for vel, one for angle) is better if you can freely move in any axis of movement (i.e a player in a shooting game), but we can't. (Tested this also, and it felt really weird and hardly worked).

I'd suggest if we'd like to do this, we change acceleration to the triggers (forward = Right Trigger, reverse = Left Trigger), and then can use one joystick for the steering. Haven't played on in a while, but I believe this is how traditional racing games are done as well.

maximecb commented 6 years ago

What's the status of this PR? Are you using L/R triggers after all?

bhairavmehta95 commented 6 years ago

No, the triggers seem too inconvenient with every method I tried (albiet that really wasn't too many), so I just added the changes of:

X button now stops the recording and deletes in no matter what. If episode finishes when recording, recording is now stopped & saved and the episode resets.

I think that its currently "good enough", but if our current control scheme becomes too inconvenient in the future, I can readdress it?

maximecb commented 6 years ago

:+1: