search

duckietown / gym-duckietown

Self-driving car simulator for the Duckietown universe
http://duckietown.org
Other
51 stars 19 forks source link

Frame skip #58

Closed bhairavmehta95 closed 6 years ago

bhairavmehta95 commented 6 years ago

Adding an optional frame-skip parameter, and exposing for use in the simulator. (Addressing #58)

bhairavmehta95 commented 6 years ago

Sorry, I checked out of an old branch and that's why there are tons of commits.

maximecb commented 6 years ago

Seems like a good idea, but, small point: feels like the frame skip parameter should probably be zero by default, to clearly indicate that this is disabled, not 1. How does it work with the Atari environments?

bhairavmehta95 commented 6 years ago

In Mujoco, frame_skip implies frequency of actions, so a frame_skip of 1 = act every frame.

https://github.com/rll/rllab/blob/master/rllab/envs/mujoco/mujoco_env.py#L78 https://github.com/rll/rllab/blob/master/rllab/envs/mujoco/mujoco_env.py#L186