search

duckietown / gym-duckietown

Self-driving car simulator for the Duckietown universe
http://duckietown.org
Other
52 stars 19 forks source link

Python 2 compatibility #95

Closed AndreaCensi closed 5 years ago

AndreaCensi commented 5 years ago

@breandan I am not sure how to deal with the "ci/dockercloud" tests. There are no logs or anything.

liampaull commented 5 years ago

@takeitallsource @AndreaCensi is this ready to merge? not currently assigned to anyone

AndreaCensi commented 5 years ago

@liampaull ready to merge

bhairavmehta95 commented 5 years ago

These changes have broken the scripts that people use to try the simulator. We need to make sure that we at least try to move around with ./manual_control.py and ./free_camera.py, because those either didn't compile (due to the added dependency on torch), and something in these changes has broken the way that those scripts interacted with the environment.

The CircleCI are set up to basically check if the code compiles, and some test actions can be run, but the only way to check keyboard control is to actually run the code ourselves.

liampaull commented 5 years ago

@bhairavmehta95 should we revert ?

bhairavmehta95 commented 5 years ago

No we fixed it in the other PR