search

duckinator / bork

A Python build and release management tool.
https://bork.readthedocs.io
MIT License
12 stars 2 forks source link

run: Deal with lists being put in the configuration file #232

Closed nbraud closed 3 years ago

nbraud commented 3 years ago

I just noticed that Bork will accept lists, in command definitions, and pass them to subprocess.run, which seems to silently discard all but the first element.

It seemed sensible to interpret it instead as a list of commands to execute sequentially; doing it in parallel could be cute, but also rather silly >_>'

If this seems like a bad idea, please make sure that lists are rejected instead. The current situation is just very confusing. :3

nbraud commented 3 years ago

(Force pushed to fix a mistake in a commit message)

duckinator commented 3 years ago

Honestly, I didn't even realize that passing lists worked at all. I'm okay with this as-is. :+1:

bors r+

bors[bot] commented 3 years ago

Build succeeded: