bork-generated changelogs include last PR from previous release

duckinator / bork

A Python build and release management tool.

https://bork.readthedocs.io

MIT License

12 stars 2 forks source link

bork-generated changelogs include last PR from previous release #332

Open duckinator opened 9 months ago

duckinator commented 9 months ago

e.g., v7.0.1 includes the PR for merging v7.0.0:

but this is in spite of the fact that the PR is included in the info for v7.0.0:

v7.0.0 also included the PR for the v6.0.1 release.

The relevant code is probably bork.github_api.GithubApi._relevant_to_changelog().

nbraud commented 3 weeks ago

Yes, relevant_to_changelog relies on a (strict) comparison of merge time and release time, as reported by Github's API.

I think the ideal solution would be to use the actual git history (or some API which exposes info from it) as this would be a lot more robust, even in cases where multiple release branches exist etc.