load_pyproject: Prefer the stdlib's TOML parser when available

duckinator / bork

A Python build and release management tool.

https://bork.readthedocs.io

MIT License

12 stars 2 forks source link

load_pyproject: Prefer the stdlib's TOML parser when available #344

Closed nbraud closed 9 months ago

nbraud commented 9 months ago

Upstream development of the toml package seem to have mostly stalled back in 2020.

Moreover, I'm not aware of any reason to prefer it over the stdlib's parser (introduced in Python 3.11) and that's one less dependency to care about. =^.^'=

nbraud commented 9 months ago

This is cursed:

test_repo_bork runs python -m bork in a clone of the bork repo;
the Python interpreter looks for the bork module, finds the bork/ folder in the (current) working directory;
the version of bork being run is the one from the repo's default branch, rather than the one pytest was called against;
because a dependency was removed in this PR (for Py3.11 and later), the version of bork in the default branch fails to run in the pytest environment.

nbraud commented 9 months ago

Pushed a fix for the underlying issue (the version of bork being run wasn't the version under test) as part of #340 : 68864976c1ab43d1f81b2060b6cabdcc167af014