Stub out `bork download` to `homf`

duckinator / bork

A Python build and release management tool.

https://bork.readthedocs.io

MIT License

12 stars 2 forks source link

Stub out `bork download` to `homf` #362

Closed nbraud closed 3 months ago

nbraud commented 3 months ago

[x] add API surface in Homf to select other PyPI repos (like the test instance)
[x] stub bork.api.download out to homf, removed the individual downloaders

Not strictly-necessary, but minor improvements made things easier:

[x] sort (and document more) dependencies in pyproject.toml
[x] Simplify bork.api.download with match statement Using pattern matching induces a dependency on Python 3.10 or later; 3.8 is end-of-life in October, but technically 3.9 receives security fixes until next year.

duckinator commented 3 months ago

wrt homf, I opened: https://github.com/duckinator/homf/issues/9

I'm fine dropping 3.8 support a bit early, but let's revisit the Python 3.9 decision after I've had some sleep and things settle down a bit here.

https://versions.do1g.com/ shows the big distro families all seem to be on 3.10+, though, fwiw.

nbraud commented 3 months ago

the big distro families all seem to be on 3.10+

Yes, that was my thinking: all major distros have long updated to 3.10 or later, and bork is a dev tool so we can presumably expect users not to run oldoldoldoldstable or such.

nbraud commented 3 months ago

For some reason, selecting a specific commit or branch with a dependency pulled from git does not seem to work, so I just pointed it at my fork of homf, and changed its default branch >_>'

~~Hopefully~~ Thankfully that works

nbraud commented 3 months ago

This should be good to merge once:

[x] the remaining CI task goes green: Github show it red right now, but I requested a re-run ;
[x] homf#10 is merged ;
[x] an homf release is cut, and the dependency spec in this PR is updated ;
[x] we decide whether to drop Py3.9 support.

nbraud commented 3 months ago

Found some more dead code with vulture and the diff stats are really pleasing now~ :heart:

duckinator commented 3 months ago

Homf v1.1.1 is released. (There was a slight technical issue with v1.1.0 lol)

nbraud commented 3 months ago

Thanks again Ellen :heart: I marked the PR as ready, since all that's missing is deciding whether we are fine dropping Py3.9 support

duckinator commented 3 months ago

Given that Python 3.9 is in "source-only security updates" mode and most things are on 3.10+, I'm fine with dropping 3.8 + 3.9 support.