duckinator / bork

A Python build and release management tool.
https://bork.readthedocs.io
MIT License
12 stars 2 forks source link

builder: refactor, remove implicit global state #371

Closed nbraud closed 1 month ago

nbraud commented 1 month ago

PS: I just realised I could just squash all those commits together, given that I did a few minor refactors... then rewrote the entire hecking file >_>'

nbraud commented 1 month ago

Oops I forgot to fix pypi.Uploader.upload (Done, obviously~)

PS: How did mypy not scream about calling a non-existent function? :scream_cat:

nbraud commented 1 month ago

@duckinator There's something really fucky going on, I keep hitting mistakes which mypy should have caught but didn't

nbraud commented 1 month ago

Squashed down all the fixups now that the tests pass

nbraud commented 1 month ago

I just realised, filesystem-independence isn't really meaningful for builder, since that could only arise from a bug in build.ProjectBuilder, so I guess I'll leave the testing to that for this PR, and start on remolishing the rest of the API :smiling_imp: