duckinator / parts.horse

A website documenting electrical components.
https://parts.horse
MIT License
3 stars 1 forks source link

Port parts.horse to the Quart ASGI framework #91

Closed nbraud closed 3 years ago

nbraud commented 3 years ago

Motivation

Drive-by changes

All those were more-or-less necessary for me to be able to hack on :

Additionally, I made a few cleanups in lib.model.Part:

Missing things

duckinator commented 3 years ago

@nbraud this looks really good so far! feel free to poke me on Signal if you want me to look at something. :heart:

nbraud commented 3 years ago

@duckinator I fixed most of the linting issues; the rest are things I didn't touch, except for one (no-else-return) where I weakly disagree with the linter and I'd leave it up to you whether to fix the linter's config.

nbraud commented 3 years ago

Regarding the test failure in CI, I suspect there's something very wonky going on:

ImportError: cannot import name 'cache' from 'functools'

PS: Nevermind, it seems functools.cache was introduced in Py3.9 >_>'

AstraLuma commented 3 years ago

... except for one (no-else-return) where I weakly disagree with the linter and I'd leave it up to you whether to fix the linter's config.

Totally agree with you there. It's a dumb rule.

nbraud commented 3 years ago

Found some little warts, will fix them ASAP.

Done :)

nbraud commented 3 years ago

@duckinator I ended up taking care of testing, in no small part thanks to Quart's testing howto... and it found me a bug in my last commit (where I tried to simplify the search template)

duckinator commented 3 years ago

bors r+

aaaaa thank you so much! :purple_heart:

nbraud commented 3 years ago

You are very welcome :purple_heart:

bors[bot] commented 3 years ago

Build succeeded: