search

ducksboard / gridster.js

gridster.js is a jQuery plugin that makes building intuitive draggable layouts from elements spanning multiple columns
http://gridster.net/
MIT License
6.03k stars 1.2k forks source link

Unit tests for gridster #163

Open andreas opened 11 years ago

andreas commented 11 years ago

Hi there,

People seem to have lots of issues with gridster, and most of the time try to explain with pictures or videos. I propose to require new issues to have a failing unit test in the future.

I've written some unit tests myself to illustrate some bugs I've found in gridster, and hope they can be used as a starting point for other people. Fixes for the failing test cases are included in this pull request as well.

I've added a max_rows-option to make testing easier (otherwise it's hard to control the number of rows/cols).

dustmoo commented 11 years ago

Wonderful Andreas, this is great

On Wed, May 1, 2013 at 2:20 AM, Andreas notifications@github.com wrote:

Hi there,

People seem to have lots of issues with gridster, and most of the time try to explain with pictures or videos. I propose to require new issues to have a failing unit test in the future.

I've written some unit tests myself to illustrate some bugs I've found in gridster, and hope they can be used as a starting point for other people. Fixes for the failing test cases are included in this pull request as well.

I've added a max_rows-option to make testing easier (otherwise it's hard

to control the number of rows/cols).

You can merge this Pull Request by running

git pull https://github.com/andreas/gridster.js master

Or view, comment on, or merge it at:

https://github.com/ducksboard/gridster.js/pull/163 Commit Summary

  • Unit tests for gridster.
  • Git ignore VIM temp files.
  • Avoid extra rows/cols unless necessary on resize.
  • Move widget up after resize if possible.
  • Fix add_faux_cols.
  • Allow max_rows option.

File Changes

  • M .gitignorehttps://github.com/ducksboard/gridster.js/pull/163/files#diff-0(4)
  • A libs/syn.jshttps://github.com/ducksboard/gridster.js/pull/163/files#diff-1(2490)
  • M src/jquery.gridster.jshttps://github.com/ducksboard/gridster.js/pull/163/files#diff-2(14)
  • M test/jquery.gridder.htmlhttps://github.com/ducksboard/gridster.js/pull/163/files#diff-3(60)
  • M test/jquery.gridder_test.jshttps://github.com/ducksboard/gridster.js/pull/163/files#diff-4(91)

Patch Links:

dustmoo commented 11 years ago

Hi Andreas, I will be working to integrate your unit tests as I merge with my fork. THanks for the contribution.

stefek99 commented 11 years ago

That's huge - 2.5 kloc!

So much effort...

Is it worth merging?

andreas commented 11 years ago

The vast majority of those lines are syn.js. If you can come up with another way of unit testing gridster without that dependency, I'm all for it.

304NotModified commented 9 years ago

This never got merged?