search

ducksboard / gridster.js

gridster.js is a jQuery plugin that makes building intuitive draggable layouts from elements spanning multiple columns
http://gridster.net/
MIT License
6.03k stars 1.2k forks source link

Add the required copyright message for underscore code #297

Closed martinwoodward closed 10 years ago

martinwoodward commented 10 years ago

When looking through the code I noticed that you'd pulled in some code from underscore but hadn't included the full copyright message as required by underscore's license. Just wanted to tidy this up.

Let me know if I should generate the /dist folder and include in the commit. Also let me know if I need to tidy up the commit any as this is my first time contributing to gridster not sure if I'm following the commit convention guidance correctly.

halfdan commented 10 years ago

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

I wouldn't exactly call throttle and debounce a substantial portion of underscore.js.

So :-1: from me.

martinwoodward commented 10 years ago

That's fair enough - just passing along the feedback from the experts that we pay lots of money to when looking at this type of stuff at the company I work for. Just passing along the changes I needed to make to keep them happy so that everyone can benefit.

vieron commented 10 years ago

Rebased here 6f207230393f068bcab13f21b547c708f9fc3983. Thanks!