ducksboard / gridster.js

gridster.js is a jQuery plugin that makes building intuitive draggable layouts from elements spanning multiple columns
http://gridster.net/
MIT License
6.04k stars 1.2k forks source link

Fix a bug in Gridster.add_faux_cell method #440

Open CodeAnimal opened 9 years ago

CodeAnimal commented 9 years ago

This line checks that the row doesn't already exist in the gridmap array; if it does then it doesn't need to be pushed to the faux_grid array.

Otherwise, this function introduced a bug when I was dynamically adding widgets that had a row height > 1 as the first widget added. This function would overwrite it's second row entry with "false", making it seem that no element was in row 2, when actually there was. Any subsequent widget added would end up being at row 2 (rather than row 3, as the first widget already occupied the first 2 rows) because Gridster doesn't know that a widget was there.