fix quote for text with '/', such as branch 'dev/test'

ducksboard / libsaas

Python library to take the pain out of using SaaS APIs. It's like an ORM for SaaS!

http://ducksboard.github.io/libsaas/

MIT License

384 stars 82 forks source link

fix quote for text with '/', such as branch 'dev/test' #99

Closed david-stream closed 6 years ago

david-stream commented 6 years ago

When branch such as 'dev/test' use quote_any function, port.quote will let safe='/' as default. So branch whose text contains '/' will not work in restful api request GET /projects/:id/repository/branches/:branch Just change port.quote(port.to_b(val)) to port.quote(port.to_b(val), safe='') will be ok.

david-stream commented 6 years ago

The command "pip install requests==0.14.1 --use-mirrors" failed and exited with 2 during

wulczer commented 6 years ago

Thanks for the PR, sorry it took a while to look at. The test failures are something that needs to be addressed separately, but the PR itself looks great.