search

ducky / play-midnight

(DEPRECATED) Enjoy your music at night. All the time.
86 stars 92 forks source link

Color matching on GPM logo #28

Closed nilsmedina closed 8 years ago

nilsmedina commented 8 years ago

Hello,

Currently the GPM logo in the top left corner is orange (default theme). It would be nice if it matched the custom accent color, but it seems it is not html but a set image. Therefore I think it could be set to a light grey to fit with any custom accent color?

Thanks again for the brilliant extension! Cheers

geudrik commented 8 years ago

That image is the favicon, so setting it either requires b64 injection of an image, or a hard-coded URL. href="data:image/png;base64,xxxx in the favicon would allow for generated favicons to be injected, but IIRC chrome caches that.

ducky commented 8 years ago

I think he's actually talking about the Play Music logo in the sidebar. The way I have my js set up right now it's kind of annoying to get it working since Google uses something React-like that automatically re-renders the image if you change it. I've had this on my list for my next version of PM when I get around to it though.

ducky commented 8 years ago

Just fixed this one up in 37b9d65 after looking into it with some css changes instead of js