ducky / play-midnight

(DEPRECATED) Enjoy your music at night. All the time.
86 stars 92 forks source link

New elements/pages in a recent update are unthemed. #29

Closed bkromhout closed 8 years ago

bkromhout commented 8 years ago

Hi there, just wanted to let you know that as of the (very recent) update to Google Play Music, there are a couple of unthemed areas (not unexpected, since they appear to be totally new).

If you need any extra detail, don't hesitate to ask!

Right-hand-side "Playlists" Sidebar

A new sidebar specifically for playlists has been added. You access the sidebar using the new button in the top bar which has (aptly) a playlist icon: screen shot 2016-08-19 at 2 47 31 pm

And then it slides out, and currently looks like this: screen shot 2016-08-19 at 2 46 20 pm

"Upgrade to family plan" Page

There is now a new page accessible in the existing (left-hand-side) sidebar when you click button which is above the "Play Midnight" one in this screenshot: screen shot 2016-08-19 at 2 53 52 pm

It takes you to a completely new page, which is scrollable, that has some issues on the light and dark areas: screen shot 2016-08-19 at 2 54 46 pm The only thing difficult in the light area is that the text next to the checkmark at the bottom is difficult to read

screen shot 2016-08-19 at 2 55 04 pm The dark area is much worse; the header text of "What You'll Get", as well as the table columns' headings ("Features", "Free", and "Unlimited" from left to right) are nearly unreadable.

In addition, while I'm unsure if this is a Google-side or Play Midnight-side issue, the hamburger button which flies out the left-hand sidebar is not present on this screen.

ducky commented 8 years ago

Yeah, I just heard word of these things on Reddit as well. Appreciate you creating the issue.

I'll try and tackle some of the bigger issues this weekend.

And just to answer your question about the hamburger, that is indeed from Play Midnight, due to using the static sidebar option.

Thanks again, Chris

bkromhout commented 8 years ago

No problem!

I don't use the static sidebar option, but since it now appears that the left sidebar (well, neither of them really) can actually stay on the screen at all times, I can understand how it might break it. Now they auto-hide when you click off of them.

ducky commented 8 years ago

Hey bud, I've worked on getting some things fixed up and removed a few broken options. However, I'm not seeing the "Upgrade to Family Plan" on my end. Might be cause I'm on a trial right now or something.

Could you see if you can shoot me a link to the family plan page and I'll try and get it updated on the next go? Thanks!

bkromhout commented 8 years ago

Sure thing, here you go: https://play.google.com/music/listen?u=0#/sulp

ducky commented 8 years ago

Welp, sadly I can't actually get to that page. I just get redirected to the main site. If you want to take a stab at it and submit a PR I'd be happy to pull it in for you.

Thanks

bkromhout commented 8 years ago

I was just about to see what I could figure out this afternoon, only to find that the page is no longer appearing for me 😒 If it appears again in the future, I'll look at it.

On a totally different note, panel which shows the list of currently playing songs (the "queue" I guess?) is suddenly showing some odd behavior, the currently playing song's row has some unthemed elements as you can see here:

screen shot 2016-09-09 at 12 06 42 pm

I'll see if I can make heads-or-tails of anything, but I'm no whiz, so I can't promise anything.

Edit: Yeah, I have to admit that this is a bit over my head, sorry!

geudrik commented 8 years ago

Confirming that I'm also seeing now playing row issues, as shown above.

screen shot 2016-09-13 at 11 24 04 am

ducky commented 8 years ago

Fixed issues with now playing row styling. Reopen a new issue if the family page happens to show up again. Thanks!