ducky / play-midnight

(DEPRECATED) Enjoy your music at night. All the time.
86 stars 92 forks source link

Firefox WebExtension support #42

Closed encounter closed 6 years ago

encounter commented 7 years ago

A few things of note:

ducky commented 7 years ago

Whew, appreciate you taking all this on. I'm already in love with your eslint/fetch changes since I've been using those at work.

By chance could you point me in the right direction for getting this guy up and running? I sadly haven't taken the time to look into Firefox development in the last year or two and I'm sure a ton has changed. Thanks again for working on this!

encounter commented 7 years ago

I've been using about:debugging to load the folder as a temporary extension (like Chrome's "Load unpacked extension"). Then you'll want to use the Debug option that shows up, since content script errors show up there instead of the Play Music page's console.

ducky commented 6 years ago

I just released version 3.0.0, which is a complete rewrite. I've peeked into the Firefox stuff a little bit, which actually works almost perfectly out of the box, with a few caveats.

Other than those few issues, it's looking really promising! If you wanna poke around a bit and see if you can find any other stuff, I'd definitely appreciate the help. I don't use Firefox as a daily driver so I haven't had as much of a chance to dig in yet with doing all the Chrome rewrite.

Appreciate the help. 👍

encounter commented 6 years ago

Great! I'll open a new PR if I get a chance to poke around at it.