search

ducky64 / labelmaker

Labelmaker using SVG templates and CSV data
GNU General Public License v2.0
8 stars 5 forks source link

Cyrillic fix #7

Closed zeridon closed 8 years ago

zeridon commented 8 years ago

Fix display of cyrillic characters in rendered files

ducky64 commented 8 years ago

Not sure this is a good idea: sys.setdefaultencoding is very much a hack. I also assume this works as-is on Python 3.x (which vastly improved Unicode support), and adding hacks to work on an older Python is undesirable.

zeridon commented 8 years ago

Inclusion is always at your discretion. If you feel this is too much of a hack (which it is) feel free to reject.

ducky64 commented 8 years ago

Since there is an elegant solution (use Python 3!), I don't think including a hack is a good idea. Though anyone dead set on using Python 2 can try to manually apply the diff found here.