dunghuynh1990
commented
7 years ago 👍 Congratulation on finishing the Tip Calculator. Here are some quick comments about your prework:
Tip View:
- Great UI and creativity for splitting information.
- You can try to display currency in the textfield. Right now it only shows the currency in place holder. For example, UITextfield will display $100 or 100.000 VNĐ.
- You shouldn't let the user enter invalid number, should you? I can enter bunch of leading zeros and decimal points. (For example: 0........00000)
Setting View:
- Good usage of NSUserDefaults. This is one of the methods to pass the data from multiple viewController.
- I recommend you add some
UILabelfor user to identify Min, Medium, Max percentage - You should validate user input. Just let the user input 1 number 2 decimal places (19.99)
- Like Tip View, I can enter bunch of leading zeros and decimal points. (For example: 0........00000)
Optional Suggestions to Improve
- You can use slider or let user input the number of person, right now it can only split the bill for 4 people
- There is case that the text field has no data but it still save the last bill. (see the attached photo)
- Try
UIView.animateWithDurationfunctions to add animations.
I encourage you to try out the optional tasks to make your app better.
Regards, Dung Huynh
ducminh1012
Thank you for your Swift submission, Duc Le! 😋 Everything looks good with the format of your submission. We'll be reviewing your submission soon!