search

ducompsoc / durhack

🎊 DurHack website
https://durhack.com
3 stars 6 forks source link

Gallery, Guilds and Footer components #130

Closed SatapasT closed 1 month ago

SatapasT commented 1 month ago

Pull request for the Gallary, Guilds and Footer components

willwoodward commented 1 month ago

I've kept the footer component (the one that has MLH code of conduct on) inside the footer component, and the website "footer" I rather ambiguously just named "end" 😂 Should we just get rid of the old footer and replace it with this one?

Lordfirespeed commented 1 month ago

Yes, probably, but that's an easy fix down the line

I have some unpushed commits for this branch - @SatapasT basically the carousel component is good, but it's too inflexible to be its own component. Since the images are hardcoded, it should be called 'GalleryCarousel' or something. For it to just be 'Carousel', it should be possible to 'slot in' images on a per-instance basis

The way that's usually done in React is by passing in children components - you can see an example once I've pushed commits

SatapasT commented 1 month ago

Cheers, I'll take a look when its pushed