search

ducompsoc / website

Website assets for Durham University Computing Society
https://www.compsoc.tech/
MIT License
5 stars 1 forks source link

Trying to make the contact page look better! #51

Closed singhuist closed 7 years ago

singhuist commented 7 years ago

Those previous tiny icons which were just images downloaded from the web are now big beautiful font-awesome icons which serve as links to the respective social media pages.

We can later mess around with colours and effects upon hovering etc.

Also getting rid of email column, instead making a form which we need to activate

singhuist commented 7 years ago

Already made a commit with updated form, so this also got updated

AlistairMadden commented 7 years ago

We really don't want to be mixing PHP in with this... I'll take a look at how to do it the Node.js way :)

AlistairMadden commented 7 years ago

Right, we need much more to be resolved if we're to merge develop into master. In future it would also be best practice to work on a feature in it's dedicated branch (separated by pages for the minute). I expect page branches to be permanent and any commits which do not fall neatly into a page to have a separate branch created (branching from the develop branch) which can be deleted after the work has been merged into develop via a pull request.