Data readers for `duct.core.merge`

duct-framework / core

The core library of the Duct framework

76 stars 21 forks source link

Data readers for `duct.core.merge` #26

Closed g7s closed 5 years ago

g7s commented 5 years ago

Currently we cannot use duct.core.merge tagging (i.e. merge/distinct, merge/displace etc) on non clojure.lang.IObj values in an edn configuration.

Is it possible to create data readers to do the tagging?

EDIT: I mean ofc we can pass our own data readers in duct.core/read-config but shouldn't Duct provide the readers by default?

weavejester commented 5 years ago

That's not a bad idea. I'd accept a PR for it.

g7s commented 5 years ago

Sure. Let me see what I can do

weavejester commented 5 years ago

Fixed by #27.