duct-framework / core

The core library of the Duct framework
76 stars 21 forks source link

Add keyword coercion (Keyword symbol) in #duct/env #39

Closed arichiardi closed 2 years ago

arichiardi commented 2 years ago

Implements #38.

atomist[bot] commented 2 years ago

Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:

atomist[bot] commented 2 years ago

Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:

atomist[bot] commented 2 years ago

Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:

weavejester commented 2 years ago

Let's make it Keyword instead.

arichiardi commented 2 years ago

@weavejester anything else we need to do for merging this one?

weavejester commented 2 years ago

I don't get notified about new commits, so it's often worth adding a comment, otherwise I won't know if there have been changes :)

Can you change the commit message to:

Add keyword coercion to #duct/env (fixes #38)

There's no need to add any more to the commit message.

arichiardi commented 2 years ago

I can definitely do that, FWIW the second part is content and won't appear in git log with --pretty=oneline - it is usually recommended to have head + content. In any case doing it and writing you back when done

arichiardi commented 2 years ago

Ok done

weavejester commented 2 years ago

FWIW the second part is content and won't appear in git log with --pretty=oneline - it is usually recommended to have head + content.

I'd generally agree, but in this case it doesn't add any useful information so should be omitted.