Closed arichiardi closed 2 years ago
Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:
Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:
Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:
Let's make it Keyword
instead.
@weavejester anything else we need to do for merging this one?
I don't get notified about new commits, so it's often worth adding a comment, otherwise I won't know if there have been changes :)
Can you change the commit message to:
Add keyword coercion to #duct/env (fixes #38)
There's no need to add any more to the commit message.
I can definitely do that, FWIW the second part is content and won't appear in git log with --pretty=oneline
- it is usually recommended to have head + content. In any case doing it and writing you back when done
Ok done
FWIW the second part is content and won't appear in git log with --pretty=oneline - it is usually recommended to have head + content.
I'd generally agree, but in this case it doesn't add any useful information so should be omitted.
Implements #38.