Datasource cannot be closed when `reset` or `halt`

duct-framework / database.sql.hikaricp

Integrant methods for a SQL database connection pool

5 stars 6 forks source link

Datasource cannot be closed when `reset` or `halt` #1

Closed zerg000000 closed 7 years ago

zerg000000 commented 7 years ago

When upgrade to database.sql.hikaricp 0.3.0, when reset the following exception is thrown.

(reset)
ClassCastException net.ttddyy.dsproxy.support.ProxyDataSource cannot be cast to com.zaxxer.hikari.HikariDataSource  hikari-cp.core/close-datasource (core.clj:213)
*e
=>
#error{:cause "net.ttddyy.dsproxy.support.ProxyDataSource cannot be cast to com.zaxxer.hikari.HikariDataSource",

weavejester commented 7 years ago

Ah, whoops! I neglected to add a test to for halting the key with a :logger option. I'll get this fixed by tomorrow.