search

duct-framework / database.sql.hikaricp

Integrant methods for a SQL database connection pool
5 stars 6 forks source link

Make jdbc-url and connection-uri optional #15

Closed iarenaza closed 1 year ago

iarenaza commented 1 year ago

One important caveat for this pull request, from https://github.com/tomekw/hikari-cp#installation:

hikari-cp version 3.x targets Clojure 1.11. Version 2.14.3 was the last release for Clojure 1.9. Version 1.8.3 was the last release for Clojure 1.8. Note that hikari-cp requires Java 11 or newer. Version 2.14.3 was the last release for Java 8.

iarenaza commented 1 year ago

Also changed the commiit message as suggested.

weavejester commented 1 year ago

Perfect, thanks!