search

duct-framework / database.sql.hikaricp

Integrant methods for a SQL database connection pool
5 stars 6 forks source link

fix the logging proxy stop halt-key working #2

Closed zerg000000 closed 7 years ago

zerg000000 commented 7 years ago

fix #1 . The proxy datasource could not be closed by hikari-cp/close-datasource. Therefore, we need to unwrap the datasource before closing.

weavejester commented 7 years ago

Thanks for the fix!

Could you put type hints for .unwrap so that there's no reflection warnings, and could you change the commit message to:

Fix halt-key! method when :logger supplied
weavejester commented 7 years ago

Perfect, thanks!