search

duct-framework / docs

Documentation for Duct
21 stars 9 forks source link

Update GUIDE.md #4

Closed i0cus closed 6 years ago

i0cus commented 6 years ago

Adds two empty lines to make their code-blocks appear in the document.

weavejester commented 6 years ago

Thanks! Can you change "Added" to "Adds" in the commit message?

i0cus commented 6 years ago

Done.

weavejester commented 6 years ago

It doesn't appear to have changed?

i0cus commented 6 years ago

Oh silly me, edited the wrong thing. Can this be edited at this point, or should I do another PR?

i0cus commented 6 years ago

Cloned the fork to local and amended the commit, does that work?

(Sorry for the delay, should've done that to begin with instead of using the web fork/edit/PR thing.)

weavejester commented 6 years ago

Thanks! But you've somehow removed the commit subject line as well. Can you add it back in? Or change the commit to something more like:

Fix code blocks in GUIDE.rst

For reference, I follow the standard seven rules for my commit messages.

i0cus commented 6 years ago

Check now, please.

weavejester commented 6 years ago

Perfect, thanks!