The generated boundary protocol cannot be compiled if component's symbol contain '-'

duct-framework / duct

Server-side application framework for Clojure

MIT License

1.13k stars 51 forks source link

The generated boundary protocol cannot be compiled if component's symbol contain '-' #47

Closed zerg000000 closed 7 years ago

zerg000000 commented 8 years ago

Using gen/boundary

 (gen/boundary "ha" 'duct-framework.component.wow.Wow)

will generate code below

(ns duct-framework.boundary.ha
  (:require
    [duct-framework.component.wow])) ; this is correct

(defprotocol Ha)

(extend-protocol Ha
  duct-framework.component.wow.Wow) ; should be _ instead of -

The correct one should be

(ns duct-framework.boundary.ha
  (:require
    [duct-framework.component.wow])) 

(defprotocol Ha)

(extend-protocol Ha
  duct_framework.component.wow.Wow)

weavejester commented 8 years ago

Good catch. This'll be fixed by the next version.

weavejester commented 7 years ago

Not relevant in 0.9.0.