duct-framework / duct

Server-side application framework for Clojure
MIT License
1.13k stars 51 forks source link

#duct/resource not working with ragtime migrations #82

Closed admarrs closed 5 years ago

admarrs commented 5 years ago

Not sure if this is the correct place to post this. Trying to get ragtime migrations working with Duct core 0.7.0-beta2 and I get the following:

No implementation of method: :get-string of protocol: #'duct.migrator.ragtime/StringSource found for class: duct.core.resource.Resource

relevant config is:

:duct.migrator/ragtime { :migrations [#ig/ref :app.migration/create-table-users]}

[:duct.migrator.ragtime/sql :app.migration/create-table-users] { :up [#duct/resource "migrations/000-create-table-users.sql"] :down [#duct/resource "migrations/000-drop-table-users.sql"]}

This worked fine with Duct Core 0.6.2

weavejester commented 5 years ago

Thanks for the report. It looks like :duct.migrator/ragtime needs to be updated.

admarrs commented 5 years ago

It's being pulled in by duct/module.sql, I'm using

[duct/module.sql "0.5.0-alpha1"]

So I guess that would need updating too?