search

duct-framework / module.cljs

Duct module for developing and compiling ClojureScript
2 stars 6 forks source link

Update ClojureScript to 1.9.521 (same as duct/server.figwheel) #1

Closed scottlowe closed 7 years ago

scottlowe commented 7 years ago

I ran lein test with no issues 👌

weavejester commented 7 years ago

Thanks! Can you remove the "Exclude IntelliJ" commit from the PR?

scottlowe commented 7 years ago

I've removed the .gitignore commit, as requested. Does that mean that you'd prefer not to receive future additions to .gitignore, or are you simply indicating that you prefer a strict separation of concerns in PRs?

weavejester commented 7 years ago

Both reasons 😃

I think IDE-specific ignore directives are probably better suited to project-local ignore files, such as .git/info/ignore in the project directory, or user-local ignore files, such as the one defined by the core.excludesfile option.

So one thing I've done is to create a global .gitignore:

git config --global core.excludesfile ~/.gitignore_global

And then I've added all my IDE-specific ignore patterns to that.

scottlowe commented 7 years ago

Okay, thanks for the explanation (and education)! I was asking because the project I'm currently working on uses the duct-framework, so I may submit PRs for other modules in the future, and it's good to know what you want, what you expect and how you work 😄

weavejester commented 7 years ago

Are you using the alpha version?

scottlowe commented 7 years ago

Currently have the following dependencies:

[duct/core "0.1.1"]
[duct/module.logging "0.1.1"]
[duct/module.web "0.1.1"]
[duct/module.cljs "0.1.2"]

Project is fairly bare-bones at the moment, and we appreciate that it's early days for duct.

Background: We've started a new project and a significant requirement was that we wanted to use integrant, rather than component or mount, since we've not been satisfied with either of those in other projects.

weavejester commented 7 years ago

There shouldn't be too many significant changes in the future, but I have just released two breaking changes for 0.9.0-alpha3 that are probably worth mentioning.

The first is that from Integrant 0.4.0 onward, #ref has been changed to #ig/ref. See weavejester/integrant#12 for the discussion around that.

The second is that Duct modules from version 0.2.0 onward are self-ordering, so they no longer require the :duct.core/modules key. See the modules section of the duct/core project.

If you have any feedback around the Duct 0.9.0 alpha, I'd be interested to hear it.

scottlowe commented 7 years ago

Cheers. Much appreciated. Will update the project now.

Hey, are you actually in the UK right now? It's well after 2am there!

weavejester commented 7 years ago

It is, but I like working late :)