search

duct-framework / server.figwheel

Integrant methods for running Figwheel
4 stars 8 forks source link

clojurescript , figwheel version mismatch #2

Closed zerg000000 closed 7 years ago

zerg000000 commented 7 years ago

figwheel-sidecar 0.5.8 depends on goog.net.jsloader.load which is removed since Closure Library v20170806. However, clojurescript 1.9.908 is depends on Closure Library 0.0-20170809-b9c14c6b and this will cause throwing goog.net.jsloader.load not found when reset in duct repl.

Please consider upgrade figwheel to 0.5.13, according to Change Log the use of goog.net.jsloader.load is removed.

weavejester commented 7 years ago

Upgrading to 0.5.13 is on my todo list, but because server.figwheel reaches into the internal API of Figwheel, it's always a huge pain to upgrade.

zerg000000 commented 7 years ago

I had added the figwheel-sidecar 0.5.13 explicitly, seems not much problems.

weavejester commented 7 years ago

Are you using it from a blank target directory? I'm finding updating the dependency to 0.5.13 results in the server not compiling new files.

weavejester commented 7 years ago

Fixed. Turned out to be an error in the integration code. The internal API calls that server.figwheel uses haven't changed from 0.5.8 to 0.5.13, so this upgrade was relatively straightforward.