search

dudapiotr / ZfTable

*Not supported*ZfTable 3.1. Awesome ZF2 table / grid (and much much more) generator with huge possibilities of decorating and conditioning. Integrated with DataTables, Doctrine 2, Bootstrap 2.0 and 3.0.
http://dudapiotrek.laohost.net/
MIT License
75 stars 59 forks source link

Strict standards on AbstractTable Class #61

Open greatcloud opened 9 years ago

greatcloud commented 9 years ago

The Class "AbstractTable" should have the declaration of "initFilters" this way:

protected function initFilters(\Zend\Db\Sql\Select $query){ }

olekhy commented 9 years ago

shouldn't because $query realized nor an explicit interface.

greatcloud commented 9 years ago

Well, I cloned from repository with composer and until I declared that way; I was getting a warning.

greatcloud commented 9 years ago

I guess then in the "Base.php" the "initFilters" shouldn't be extended like this:

protected function initFilters(\Zend\Db\Sql\Select $query){ }