search

dudaster / ele-custom-skin

Create a skin for Elementor Pro Post and Post Archive widgets using Elementor templates
GNU General Public License v3.0
59 stars 10 forks source link

Elements and IDs duplicated when using Carousel #156

Closed formulaclick closed 4 years ago

formulaclick commented 4 years ago

Hi! I'm PRO user and I have a posts slider with Carousel option activated, like this: https://pasteboard.co/IWBDBr7.png

Apparently it works great, but I have a problem. Generated code cause me Accesibility errors because each post is duplicated on source code (I guess this is normal behaviour when using carousel) but also IDs are duplicated, and this is not a good practice at all and causes errors on Accesibility tests, which is important in some cases. See here: https://pasteboard.co/IWBCjT4.png

Can this be solved? Thanks

dudaster commented 4 years ago

If you select infinite scroll the swiper javascript dublicates some posts to be able to scroll seamlessly. The solution would be either to remove the infinite or feed more products to it.

formulaclick commented 4 years ago

Oh, that's true. Didn't know that option was enabled. Maybe it should be set to false by default? Thanks!

dudaster commented 4 years ago

I'll keep it in mind.