dudaster / ele-custom-skin

Create a skin for Elementor Pro Post and Post Archive widgets using Elementor templates
GNU General Public License v3.0
59 stars 10 forks source link

Custom Grid: Add Loop Item Widget custom Base HTML #338

Open shaneonabike opened 4 years ago

shaneonabike commented 4 years ago

First off thanks for building a really excellent plugin allowing so much more customization to Elementor themes.

I came across a little gotcha with a project that I am working on. Essentially, I noticed that the plugin modifies some of the html output (compared to just using a normal loop without a grid).

In the output you are going to get the following:

<div id="post-389" class="elementor-post elementor-grid-item ecs-post-loop post-389 recettes type-recettes status-publish has-post-thumbnail hentry recette-recettes-des-iles">

If you turn off the grid then you are going to get :

<article id="post-389" class="elementor-post elementor-grid-item ecs-post-loop post-389 recettes type-recettes status-publish has-post-thumbnail hentry recette-recettes-des-iles">

Normally, this wouldn't really bother me BUT when using elementor-super-cat it is specifically looking for the article tag. Could we either change it from a div to the original article tag OR allow folk to modify the base html themselves? This is happening somewhere around your debugging end part code.

(Also a side note I noticed there is some debugging that is still being output in the form of etc)

dudaster commented 3 years ago

Can’t you choose the tag of the section to be article from elementor?

shaneonabike commented 3 years ago

I can try that but this would change the theme response quite a bit, but I am happy to give it a go for sure. I am still curious why the output is changed though..