dudaster / ele-custom-skin

Create a skin for Elementor Pro Post and Post Archive widgets using Elementor templates
GNU General Public License v3.0
59 stars 10 forks source link

Different styled-loops not working within Archive #381

Open jaykaslo opened 4 years ago

jaykaslo commented 4 years ago

Hi, I'm currently using Ele Custom Skin on two sites. I'm using version 2.1 (Pro) on site A and version 3.0 (Pro) on site B. What's strange is... it's working fine on the OLDER version (2.1), but not working correctly on site B (with the newer version).

The issue is... I've created different loop templates for each post category. Each loop template is displaying correctly in the Archive grids on site A, but this is not working on site B. On site B, whichever template I specify under "Select a default template"... that particular template is showing up for ALL posts in the archive (regardless of category).

I've compared the settings for both sites and they look identical, so I'm wondering why it's only working on site A (using Pro 2.1), not site B (using the newer Ele Skin Pro 3.0). Is there some extra step I'm missing, or is this a known bug with the newer Ele Skin Pro 3.0?

Help greatly appreciated on this, thanks!

I'm attaching screenshots of the Elementor settings for both ArchivePosts widgets.

Screen Shot 2020-11-01 at 8 54 28 PM Screen Shot 2020-11-01 at 8 55 20 PM
dudaster commented 4 years ago

Can you tell me what conditions did you used?

jaykaslo commented 4 years ago

Hi,

I have 10 blog post categories. I’ve currently set up two loops, as shown here. (Eventually I will probably create a unique loop for each of the 10 categories.)

I set the Display Conditions for the “ARCHIVE LOOP - PODCAST” to be only visible for “podcast” category posts.

And likewise for “video” category posts…

I’ve set display conditions for my Archive template to be for ALL ARCHIVES. Below is a screenshot of the Archive template. You can see the Archive Posts widget settings. I specified “ARCHIVE LOOP - PODCAST” as the default template, but since I’ve also turned on “Enable Display Conditions”, I thought it would choose which loop template to use based on what category of post is displayed in the archive grid. As far as I can tell, this is exactly how I set this up on my other site (where it works fine), so I’m wondering why it’s not working here.

*** Note that in the display here, you can see some Podcast posts but also some Video posts, but they are both displaying using the “ARCHIVE LOOP - PODCAST” loop template. (The "ARCHIVE LOOP - VIDEO” loop template is unused.)

On Nov 2, 2020, at 3:49 AM, Liviu Duda notifications@github.com wrote:

Can you tell me what conditions did you used?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dudaster/ele-custom-skin/issues/381#issuecomment-720330529, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQHM5FSU2SZ65CQ3HB6KXOLSNZXCZANCNFSM4TG4XSBA.

djdiablox commented 3 years ago

Hi,

I have the same problem. I have 2x loops - 1x for a standard product, 1x for a featured product. 1st loop is set to exclude all products with the category featured 2nd loop is set to include all products with the category featured

image image

When I enable the option labeled Enable Display Conditions on my Posts Archive object or Posts object, I select the standard loop as the default and I would expect the featured product to have its respective skin applied. No such luck.

image

I also tried playing around with the conditions to only exclude, include all/exclude 1, exclude all/include 1. Nothing works. Alternating templates work just fine, so I was able to test the 2 loops working side by side, but I need to fix this. It's one of the main reasons I purchased the PRO version.

Is this option not working or is there any other logical way to set up the conditions???

Thanks, Dan

jaykaslo commented 3 years ago

Hi, I had emailed my reply, but looks like the screenshots did not come through (at least they're not visible here on Github.) I'm resending them here. Hoping to get this resolved soon, since all of this is basically why I bought the Pro version. Thanks!

=====

I have 10 blog post categories. I’ve currently set up two loops, as shown here. (Eventually I will probably create a unique loop for each of the 10 categories.)

Screen Shot 2020-11-02 at 8 43 36 AM

I set the Display Conditions for the “ARCHIVE LOOP - PODCAST” to be only visible for “podcast” category posts.

Screen Shot 2020-11-02 at 8 46 29 AM

And likewise for “video” category posts…

Screen Shot 2020-11-02 at 8 45 35 AM

I’ve set display conditions for my Archive template to be for ALL ARCHIVES. Below is a screenshot of the Archive template. You can see the Archive Posts widget settings. I specified “ARCHIVE LOOP - PODCAST” as the default template, but since I’ve also turned on “Enable Display Conditions”, I thought it would choose which loop template to use based on what category of post is displayed in the archive grid. As far as I can tell, this is exactly how I set this up on my other site (where it works fine), so I’m wondering why it’s not working here.

*** Note that in the display here, you can see some Podcast posts but also some Video posts, but they are both displaying using the “ARCHIVE LOOP - PODCAST” loop template. (The "ARCHIVE LOOP - VIDEO” loop template is unused.)

Screen Shot 2020-11-02 at 8 50 13 AM

dudaster commented 3 years ago

I will try to replicate this issue on my side. It should have worked

Jan-Webofka commented 3 years ago

@dudaster i have same Problem "Enable Display Conditions" doesnt work

Jan-Webofka commented 3 years ago

@jaykaslo have u solves the problem?

troiscodes commented 3 years ago

It is not working on my side neither...

dudaster commented 3 years ago

Next version will fix this issue.

moodeys commented 3 years ago

Seems I have the same issue. Using Woocommerce, it shows all products when viewing a category, instead of showing just that category products. Did you fix dudaster?

dudaster commented 3 years ago

Until the next version is out. Here is the fix for the "Enable Display Conditions" Problem:

Search for the file modules/display-conditions.php in plugin editor of the Ele Custom Skin Pro, insert at line 83:

if (!$condition_pass && $name == 'loop' && $sub_name) $condition_pass = true;

it will be released in the next version

dudaster commented 3 years ago

Seems I have the same issue. Using Woocommerce, it shows all products when viewing a category, instead of showing just that category products. Did you fix dudaster?

I don't think is the same issue. Make sure you have current query set up.

moodeys commented 3 years ago

Thanks for your quick response! I have done what you suggested, and that did not work. Basically, the issue is that using the loop, on a 'product archive' shows all products, instead of the products within the WooCommerce category. At this stage it does not appear to be able to work with WooCommerce. What do you mean by current query setup? Thanks for your help.

dudaster commented 3 years ago

You should treat the product just like any other custom post type