search

dudeofawesome / hn_flutter

Butterfly Reader for Hacker News, built with Flutter
GNU General Public License v3.0
16 stars 6 forks source link

comment rendering performance is poor with lots of children #30

Closed dudeofawesome closed 6 years ago

dudeofawesome commented 6 years ago

When a comment has lots of children, they all get rendered, even though many of them are off screen.

The way to fix this would be to build a tree of comments in the root story component, and then use that in the ListView.builder.

dudeofawesome commented 6 years ago

fixed in bd129a76f1e42ead7f6b7f1a682e1300928a6bfd