duderstadt-lab / mars-fx

BSD 2-Clause "Simplified" License
3 stars 1 forks source link

Error messages incorporation #5

Open NadiaHuisjes opened 4 years ago

NadiaHuisjes commented 4 years ago

Hi Karl,

Can you maybe add error messages in the following cases:

And maybe also

NadiaHuisjes commented 4 years ago

Another idea for an error message:

NadiaHuisjes commented 4 years ago

And a proposed warning message:

karlduderstadt commented 4 years ago

Great idea, thanks @NadiaHuisjes for keeping track of all the errors we need to response to. I have added a method in mars-fx to show error messages with a Rover Icon and so far I have added the error:

mjosch commented 3 years ago

Hi,

Concerning setting up the BDV, in case a drift column was provided I'd suggest to cross-check if the drift column is present in the metadata. Happens easily to have a typo in there and it's hard to notice without receiving an error message.

What do you think?

karlduderstadt commented 3 years ago

Good idea, I guess this would be during the creation of a new BDV entry in the metadata record that the error would be thrown?

mjosch commented 3 years ago

By default it's created without affine transform parameters and drift columns, so those are added after creation. Maybe check once the viewer is initialized ("show or export video")?

NadiaHuisjes commented 3 years ago

Another Error message idea:

karlduderstadt commented 3 years ago

Ahh yes, Nadia the NullPointer error was happening in the initialize() method before the dialog shows up. The command was doing some work with the imageDisplay to build the dialog. But if not imageDisplay is there then there is an NullPointerException.

Now I just stop running the initialize() method if the imageDisplay does not exists and actually scijava automatically makes the error message since a required input is not there...

I made this change for the other image processing commands as well.