search

duderstadt-lab / mars-fx

BSD 2-Clause "Simplified" License
3 stars 1 forks source link

NPE in point tracker when selected trace is deleted #55

Closed karlduderstadt closed 2 years ago

karlduderstadt commented 2 years ago

If there are a couple traces set in the molecule Plot and the one with Track one is removed, selecting the Track tool causing a null pointer error. When the selected Track is removed, the select should chain to the next trace or no traces should be selected.

Screenshot 2022-03-16 at 08 08 53
karlduderstadt commented 2 years ago

This issue is fixed with 06bb506a59f8afa9d57b381c87b0098c520a37c3 and closed. The tracking toggle group now works when new series are added or loaded from the rover file.

However, the logic of DataSets vs PlotSeries and the methods in classes and interfaces is pretty messy. This should be clean-up and improved in a future release, so there is one location where new datasets are added either as Datasets or PlotSeries.

Also, the list of current plot series in the DataSetOptionPane can be retrieved, but if PlotSeries ad added directly to this List, the new series tracking button will not be added to the toggle group. Instead the addPlotSeries method must be used. One option is to return an immutable list from this method.