search

dudil / fastapi_msal

A FastAPI Plug-In to support authentication authorization using the Microsoft Authentication Library (MSAL)
MIT License
43 stars 20 forks source link

Support setting config values in a .env file #9

Closed philipsd6 closed 7 months ago

philipsd6 commented 3 years ago

This is useful for me, as in development mode I can consolidate all my runtime variables in one .env file, including the MSAL config.

philipsd6 commented 3 years ago

I just noticed you removed this in daf091d:

-    class Config:
-        env_file = "fastapi_msal.env"

…any reason why? In any case, I'd prefer to support the standard .env file.

dudil commented 1 year ago

Hello @philipsd6 - I can't recall as it was long time ago. I remember vaguely that was some conflict - I'll have to check again and test.

yuenherny commented 1 year ago

@dudil In my case, I resorted to auth.cfg because I have Python paths as environment variables listed in .env file (VS Code linter couldn't lint properly). Wouldn't want to track that on VCS, right?

dudil commented 11 months ago

@philipsd6 & @yuenherny - I believe that Pydantic had since changed their way of reading values from .env files. Are you able to verify that on your end? This would be very much appreciated 🙏

github-actions[bot] commented 7 months ago

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] commented 7 months ago

This PR was closed because it has been stalled for 10 days with no activity.

yuenherny commented 6 months ago

@philipsd6 & @yuenherny - I believe that Pydantic had since changed their way of reading values from .env files. Are you able to verify that on your end? This would be very much appreciated 🙏

Hi @dudil , I believe so. Pydantic moved from declaring a Config class in V1 to using ConfigDict in V2. Pydantic V2 support for .env is available here.

Apologies for the late reply. Was occupied for the past few months.

dudil commented 6 months ago

Hi @yuenherny, Thank you for that. This was already handled with the migration to Pydantic V2.

🙏