duelingbenjos / rocketswap

8 stars 6 forks source link

Typos in rocketswap #49

Closed FlavorfulSoda closed 3 years ago

FlavorfulSoda commented 3 years ago

On popup that appears when you click withdraw rocketswap (from Tau staking)

Current: ** 10% of the yeild from all RSWP withdrawls in this contract goes to the developers of Rocketswap! It will be added automatically to the transaction total.

Suggested: Notice: Ten percent (10%) of the yield from all RSWP withdrawals in this contract goes to the developers of Rocketswap! This amount will be added automatically to the transaction total.

While this corrects typos and grammar a bit, I honestly don't know what this is supposed to mean. So does this mean 10% of my yield will be deducted from my transaction and given to the developers? If so, it should not say this amount is added. It could definitely use some clarification.

JeffWScott commented 3 years ago

Appreciate the spelling and grammar.

The 10% is enforced in the smart contract. We show you the amount you have earned in the UI minus the 10%. The subtext is there to notify you that if you happen to look at the transaction it will be 10% higher than you expected.

All of that being said, this is not the way we should be doing it. I think actually just showing the total earnings and being more visible about the 10% is a better approach.

ie. Withdrawal 100 minus 10% dev fee Get 90

duelingbenjos commented 3 years ago

I totally agree with you here Jeff - that's a better way to do it. Issue created on the trello

FlavorfulSoda commented 3 years ago

Typo in "withdrawal" is still there