duelists-unite / YGOPro2

The official Duelists Unite distribution of Unity based YGOPro2 application
https://gitlab.com/duelists-unite/ygopro2
GNU General Public License v3.0
60 stars 17 forks source link

Doublecheck the code responsible for updating decklists containing beta cards to official cards #1

Open szefo09 opened 5 years ago

szefo09 commented 5 years ago

here are the commits:

https://github.com/shadowfox87/YGOProUnity_V2/commit/209a6a9eb81b06ecb1d41e1d561f7a9fe04e22db

https://github.com/shadowfox87/YGOProUnity_V2/commit/e462cc79dd137756fd36773d60c7f14850356998

https://github.com/shadowfox87/YGOProUnity_V2/commit/0b0bbe4693e8f603d95ca0cf2a63d6b77e5ae5dd

Description of the feature: when a deck consists of beta card(s), and the beta card(s) gets updated to an official one(s), this feature is supposed to update a deck containing such card(s), so that the user doesn't have to do that manually and has a playable deck right away. In theory it should work fine, but some users reported that it deleted their decklists in the process of updating. This function could also be moved to update the decks on launch instead of the current implementation, which updates the deck when it's highlighted on deck edit window.