search

duemunk / Async

Syntactic sugar in Swift for asynchronous dispatches in Grand Central Dispatch
MIT License
4.59k stars 316 forks source link

Restore buildSettings from 2.0.0 #114

Closed toshi0383 closed 7 years ago

toshi0383 commented 7 years ago

Looks like some buildSettings related regression has been introduced in 2.0.1 (my bad), and some Carthage users are affected. I restored buildSettings by steps below. Hope this fixes #109 along the way.

  1. Extract current(2.0.1) buildSettings to xcconfigs using https://github.com/toshi0383/xcconfig-extractor .
  2. Checkout 2.0.0 tag and do the same thing but to AsyncTests/Async.xcodeproj/project.pbxproj, not Async.xcodeproj.
  3. Overwrite Step 1's xcconfigs with Step 2's.
  4. Fix some compile errors.

I also tried extracting buildSettings from Async.xcodeproj at 2.0.0, but there wasn't important difference from AsyncTests/Async.xcodeproj/project.pbxproj at 2.0.0 (which Carthage was using). But I noticed that APPLICATION_EXTENSION_API_ONLY = YES was only configured in former one. So I think #77 regression was introduced before 2.0.0 .

toshi0383 commented 7 years ago

🚀