search

duemunk / Async

Syntactic sugar in Swift for asynchronous dispatches in Grand Central Dispatch
MIT License
4.59k stars 316 forks source link

Update to Xcode 9 & Swift 4 #122

Closed okitsutakatomo closed 7 years ago

okitsutakatomo commented 7 years ago

This updates the project to the configuration of Xcode 9 and to use Swift 4 and convert Swift4 syntax.

ldiqual commented 7 years ago

@duemunk Would you mind taking a look at this PR and tell us what else can be done to get it merged? It's a bit unsafe for us to rely on third-party branches :/

duemunk commented 7 years ago

The branch is failing on CI. Sorry for it being responding sooner.

rolandkakonyi commented 7 years ago

You have to change the .travis.yml from: osx_image: xcode8 to osx_image: xcode9.1

Then it should pass.

rsaarloos commented 7 years ago

Any update on this one, changes look good

vldalx commented 7 years ago

@duemunk
The brunch is failing on CI because Xcode 8 does not support Swift 4. You have to change the settings as described above by @rolandkakonyi

Please, merge the PR. Your framework is quite popular.

duemunk commented 7 years ago

@vldalx (or anyone really) Feel free to do the change in the .travis.yml file to make the PR not fail CI :)

vldalx commented 7 years ago

@okitsutakatomo Could you update the PR according to the previous comment?

rsaarloos commented 7 years ago

I made a new PR for this see #123 (should be successfully pass the checks of the CI)