duemunk / Async

Syntactic sugar in Swift for asynchronous dispatches in Grand Central Dispatch
MIT License
4.59k stars 316 forks source link

AsyncSwift.podspec is outdated #124

Closed vldalx closed 7 years ago

vldalx commented 7 years ago

When I try to install that framework using CocoaPods then 2.0.1 version will be installed. Any particular version is not specified in my Podfile. Furthermore, the latest version should contain the recent changes related to Swift 4 support.

duemunk commented 7 years ago

I'm getting this error when trying to push to pod trunk:

** BUILD SUCCEEDED **

   Testing with xcodebuild. 
 -> AsyncSwift (2.0.4)
    - ERROR | file patterns: The `source_files` pattern did not match any file.

I'm not CocoaPods, so can someone that does see what changed since the config doesn't work anymore?

vldalx commented 7 years ago

I've created RP for this issue

duemunk commented 7 years ago

New error:

The following build commands failed:
    Check dependencies
(1 failure)
   Testing with xcodebuild. 
 -> AsyncSwift (2.0.4)
    - ERROR | xcodebuild: Returned an unsuccessful exit code.

[!] The spec did not pass validation, due to 1 error.
vldalx commented 7 years ago

because testAfterGCD is failed. But the test's code looks fine.

vldalx commented 7 years ago

fix for the test is here @duemunk once you are merged the fix then remove 2.0.4 tag from the old commit and add to the new one

rlam3 commented 7 years ago

I don't see any pod updates either. Is there something wrong on cocoapods end?

vldalx commented 7 years ago

@duemunk let's finish what we started. I fixed testAfterGCD test. Please, merge the PR. Then either move 2.0.4 tag to the last commit or add a new one, update podspec file

duemunk commented 7 years ago

Another day, another CocoaPods issue:

=== CLEAN TARGET AsyncSwift OF PROJECT Pods WITH CONFIGURATION Release ===

Check dependencies
“Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.

** CLEAN FAILED **

The following build commands failed:
    Check dependencies
(1 failure)
=== BUILD TARGET AsyncSwift OF PROJECT Pods WITH CONFIGURATION Release ===

Check dependencies
“Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.

** BUILD FAILED **

The following build commands failed:
    Check dependencies
(1 failure)
   Testing with xcodebuild. 
 -> AsyncSwift (2.0.4)
    - ERROR | xcodebuild: Returned an unsuccessful exit code.
duemunk commented 7 years ago

Does CocoaPods have some kind of validator you can use to check whether it would work for me to push?

vldalx commented 7 years ago

I run the command pod spec lint AsyncSwift.podspec --verbose AsyncSwift.podspec passed validation

Do you use the latest cocapods' version and Xcode as well?

vldalx commented 7 years ago

By the way, you can run the command pod spec lint AsyncSwift.podspec --verbose --swift-version=4 to be sure about the swift version 4 is fine on your side

rlam3 commented 7 years ago

i had to add :github => https://github.com/duemunk/Async.git to get it to work ....

vldalx commented 7 years ago

@rlam3 Did you mean pod spec lint command? Could you describe exactly what you did and where?

duemunk commented 7 years ago

The last error was because of the build not using the correct Xcode Command Line Tool version. Things have now been pushed.